OmniaGM commented on code in PR #16584:
URL: https://github.com/apache/kafka/pull/16584#discussion_r1715499094
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1334,6 +1334,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else {
Some(new TimestampAndOffset(RecordBatch.NO_TIMESTAMP, -1L,
Optional.of(-1)))
}
+ } else if (targetTimestamp ==
ListOffsetsRequest.EARLIEST_PENDING_UPLOAD_OFFSET_TIMESTAMP) {
Review Comment:
Can we extract this into different method and call it from here especially
that the logic here has too many if stataments ? I know the rest of
fetchOffsetByTimestamp has been done in-place but the method has grown and it
hard to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
