junrao commented on code in PR #16873:
URL: https://github.com/apache/kafka/pull/16873#discussion_r1715737193
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1170,6 +1170,10 @@ class KafkaApis(val requestChannel: RequestChannel,
debug(s"OffsetRequest with correlation id $correlationId from client
$clientId on partition $topicPartition " +
s"failed because the partition is duplicated in the request.")
buildErrorResponse(Errors.INVALID_REQUEST, partition)
+ } else if (partition.timestamp() ==
ListOffsetsRequest.EARLIEST_LOCAL_TIMESTAMP && version < 8) {
+ throw new UnsupportedVersionException(s"apiVersion must be >=8 for
EARLIEST_LOCAL_TIMESTAMP")
+ } else if (partition.timestamp() ==
ListOffsetsRequest.LATEST_TIERED_TIMESTAMP && version < 9) {
+ throw new UnsupportedVersionException(s"apiVersion must be >=9 for
LATEST_TIERED_TIMESTAMP")
Review Comment:
Actually, my suggestion is not needed since it's covered in
`RequestContext.parseRequest`.
My main question is
https://github.com/apache/kafka/pull/16841#discussion_r1715730246. It's not
clear to me why there is no test failure when we set a stable MV depending on
an unstable `ListOffset`. It would be useful to understand the testing gap and
see if we could improve the test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
