FrankYang0529 commented on code in PR #16873:
URL: https://github.com/apache/kafka/pull/16873#discussion_r1717048620
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1170,6 +1170,10 @@ class KafkaApis(val requestChannel: RequestChannel,
debug(s"OffsetRequest with correlation id $correlationId from client
$clientId on partition $topicPartition " +
s"failed because the partition is duplicated in the request.")
buildErrorResponse(Errors.INVALID_REQUEST, partition)
+ } else if (partition.timestamp() ==
ListOffsetsRequest.EARLIEST_LOCAL_TIMESTAMP && version < 8) {
+ throw new UnsupportedVersionException(s"apiVersion must be >=8 for
EARLIEST_LOCAL_TIMESTAMP")
+ } else if (partition.timestamp() ==
ListOffsetsRequest.LATEST_TIERED_TIMESTAMP && version < 9) {
+ throw new UnsupportedVersionException(s"apiVersion must be >=9 for
LATEST_TIERED_TIMESTAMP")
Review Comment:
Hi @junrao and @chia7712, thanks for review and the question. I am busy
these two days. I will take a deep dive into it on Friday.
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1170,6 +1170,10 @@ class KafkaApis(val requestChannel: RequestChannel,
debug(s"OffsetRequest with correlation id $correlationId from client
$clientId on partition $topicPartition " +
s"failed because the partition is duplicated in the request.")
buildErrorResponse(Errors.INVALID_REQUEST, partition)
+ } else if (partition.timestamp() ==
ListOffsetsRequest.EARLIEST_LOCAL_TIMESTAMP && version < 8) {
+ throw new UnsupportedVersionException(s"apiVersion must be >=8 for
EARLIEST_LOCAL_TIMESTAMP")
Review Comment:
Thank you. Update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
