ahuang98 commented on code in PR #16848:
URL: https://github.com/apache/kafka/pull/16848#discussion_r1717231902
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -409,6 +410,15 @@ public ControllerResult<BrokerRegistrationReply>
registerBroker(
for (BrokerRegistrationRequestData.Feature feature :
request.features()) {
record.features().add(processRegistrationFeature(brokerId,
finalizedFeatures, feature));
}
+ if (request.features().find(KRaftVersion.FEATURE_NAME) == null) {
Review Comment:
I see, iterating over _the controller features_ and checking brokers can
support them, vs iterating over the broker features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
