jsancio commented on code in PR #16848:
URL: https://github.com/apache/kafka/pull/16848#discussion_r1719868812
##########
core/src/test/scala/unit/kafka/server/ReplicationQuotasTest.scala:
##########
@@ -69,7 +69,7 @@ class ReplicationQuotasTest extends QuorumTestHarness {
}
@ParameterizedTest
- @ValueSource(strings = Array("zk", "kraft"))
+ @ValueSource(strings = Array("kraft")) // just for debugging
Review Comment:
TODO reminder.
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -506,7 +505,7 @@ BrokerFeature processRegistrationFeature(
}
// A feature is not found in the finalizedFeature map if it is unknown
to the controller or set to 0 (feature not enabled).
// Only log if the feature name is not known by the controller.
- if (!Features.PRODUCTION_FEATURE_NAMES.contains(feature.name()))
+ if (!finalizedFeatures.featureNames().contains(feature.name()))
Review Comment:
I don't think this is accurate. The controller may know of
transaction.version but the value is 0. Default values don't show in the
finalized versions. That is why you have these lines above:
```java
int defaultVersion =
feature.name().equals(MetadataVersion.FEATURE_NAME) ? 1 : 0; // The default
value for MetadataVersion is 1 not 0.
short finalized = finalizedFeatures.versionOrDefault(feature.name(),
(short) defaultVersion);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
