chia7712 commented on code in PR #16893:
URL: https://github.com/apache/kafka/pull/16893#discussion_r1719007373
##########
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##########
@@ -202,7 +210,17 @@ class ListOffsetsRequestTest extends BaseRequestTest {
@ParameterizedTest
@ValueSource(strings = Array("zk", "kraft"))
- def testResponseIncludesLeaderEpoch(quorum: String): Unit = {
+ def testResponseIncludesLeaderEpochWithUnstableAPIs(quorum: String): Unit = {
+ testResponseIncludesLeaderEpoch()
+ }
+
+ @ParameterizedTest
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testResponseIncludesLeaderEpochWithStableAPIs(quorum: String): Unit = {
+ testResponseIncludesLeaderEpoch()
+ }
+
+ def testResponseIncludesLeaderEpoch(): Unit = {
Review Comment:
> This could be done in a separate PR if it requires more work.
I feel following small changes can address it, so this PR should be able to
include it. @m1a2st WDYT?
```java
public short writeTxnMarkersRequestVersion() {
if (isAtLeast(IBP_2_8_IV0)) {
return 1;
} else {
return 0;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
