chia7712 commented on code in PR #16893:
URL: https://github.com/apache/kafka/pull/16893#discussion_r1720762378
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala:
##########
@@ -261,7 +257,9 @@ class TransactionMarkerChannelManager(
}.filter { case (_, entries) => !entries.isEmpty }.map { case (node,
entries) =>
val markersToSend = entries.asScala.map(_.txnMarkerEntry).asJava
val requestCompletionHandler = new
TransactionMarkerRequestCompletionHandler(node.id, txnStateManager, this,
entries)
- val request = new
WriteTxnMarkersRequest.Builder(writeTxnMarkersRequestVersion, markersToSend)
+ val request = new WriteTxnMarkersRequest.Builder(
+ config.interBrokerProtocolVersion.writeTxnMarkersRequestVersion(),
markersToSend
Review Comment:
> but can definitely be done as a followup.
@m1a2st WDYT? Sorry that I'm in traveling so can't check the code usages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
