oscerd commented on code in PR #16915:
URL: https://github.com/apache/kafka/pull/16915#discussion_r1724444205
##########
.github/workflows/docker_scan.yml:
##########
@@ -29,7 +32,7 @@ jobs:
supported_image_tag: ['latest', '3.7.0']
steps:
- name: Run CVE scan
- uses: aquasecurity/trivy-action@master
+ uses:
aquasecurity/trivy-action@d9cd5b1c23aaf8cb31bb09141028215828364bbb # master
Review Comment:
The best practice says to pin to a specific SHA
https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
##########
.github/workflows/docker_scan.yml:
##########
@@ -39,7 +42,7 @@ jobs:
exit-code: '1'
- name: Upload CVE scan report
if: always()
- uses: actions/upload-artifact@v4
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
