oscerd commented on PR #16915: URL: https://github.com/apache/kafka/pull/16915#issuecomment-2304296307
> I just noticed this PR now. I also opened a PR to address this earlier today: #16960. > > Since you opened your PR first, I'm fine if we keep this one instead of mine. Personally I'd follow https://infra.apache.org/github-actions-policy.html and pin to the specific commit hash instead of tag. In my PR for example I added the tag name as a comment alongside. For the other non official actions (`docker`, `gradle`) I think we should also pin them to specific versions instead of using flexible versions (for example `v3`). > > If we keep this PR, please link it to https://issues.apache.org/jira/browse/KAFKA-17193 too. If you look at the github hardening guide, they said if the publisher is trusted you could use the tag. Originally I was using the commit SHA too, then @mumrah reviewed the PR and suggested to use the tag. I don't have particular reason to keep this open. You already covered much of the actions with your PR, so I'm fine if you want to merge that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
