CalvinConfluent commented on code in PR #16840:
URL: https://github.com/apache/kafka/pull/16840#discussion_r1725460185
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -395,6 +403,8 @@ public synchronized void maybeAddPartition(TopicPartition
topicPartition) {
" to transaction while in state " + currentState);
} else if (isPartitionAdded(topicPartition) ||
isPartitionPendingAdd(topicPartition)) {
return;
+ } else if (coordinatorSupportsTransactionV2) {
+ txnPartitionMap.getOrCreate(topicPartition);
Review Comment:
The produce request can fail, then the partition is not actually in the
transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
