jolshan commented on code in PR #16840:
URL: https://github.com/apache/kafka/pull/16840#discussion_r1722166938
##########
clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java:
##########
@@ -53,11 +54,15 @@ public static Builder forMagic(byte magic,
ProduceRequestData data) {
maxVersion = 2;
} else {
minVersion = 3;
- maxVersion = ApiKeys.PRODUCE.latestVersion();
+ maxVersion = latestVersion;
}
return new Builder(minVersion, maxVersion, data);
}
+ public static Builder forMagic(byte magic, ProduceRequestData data) {
Review Comment:
I see. I guess I was also wondering if we need both methods. But maybe the
default latestVersion is used in tests to avoid a million changes 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
