AndrewJSchofield commented on code in PR #16963:
URL: https://github.com/apache/kafka/pull/16963#discussion_r1728820478
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java:
##########
@@ -118,49 +98,41 @@ public class HeartbeatRequestManager implements
RequestManager {
*/
private final HeartbeatMetricsManager metricsManager;
- public HeartbeatRequestManager(
- final LogContext logContext,
- final Time time,
- final ConsumerConfig config,
- final CoordinatorRequestManager coordinatorRequestManager,
- final SubscriptionState subscriptions,
- final ConsumerMembershipManager membershipManager,
- final BackgroundEventHandler backgroundEventHandler,
- final Metrics metrics) {
+ public AbstractHeartbeatRequestManager(
+ final LogContext logContext,
+ final Time time,
+ final ConsumerConfig config,
+ final CoordinatorRequestManager coordinatorRequestManager,
+ final BackgroundEventHandler backgroundEventHandler,
+ final HeartbeatMetricsManager metricsManager) {
this.coordinatorRequestManager = coordinatorRequestManager;
this.logger = logContext.logger(getClass());
- this.membershipManager = membershipManager;
this.backgroundEventHandler = backgroundEventHandler;
this.maxPollIntervalMs =
config.getInt(CommonClientConfigs.MAX_POLL_INTERVAL_MS_CONFIG);
long retryBackoffMs =
config.getLong(ConsumerConfig.RETRY_BACKOFF_MS_CONFIG);
long retryBackoffMaxMs =
config.getLong(ConsumerConfig.RETRY_BACKOFF_MAX_MS_CONFIG);
- this.heartbeatState = new HeartbeatState(subscriptions,
membershipManager, maxPollIntervalMs);
this.heartbeatRequestState = new HeartbeatRequestState(logContext,
time, 0, retryBackoffMs,
- retryBackoffMaxMs, maxPollIntervalMs);
+ retryBackoffMaxMs, maxPollIntervalMs);
this.pollTimer = time.timer(maxPollIntervalMs);
- this.metricsManager = new HeartbeatMetricsManager(metrics);
+ this.metricsManager = metricsManager;
}
// Visible for testing
Review Comment:
I've removed "Visible for testing". Because the class is abstract, it can
only be instantiated by subclassing and I prefer to leave the method as
package-private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
