AndrewJSchofield commented on code in PR #16963:
URL: https://github.com/apache/kafka/pull/16963#discussion_r1728838483
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java:
##########
@@ -467,12 +441,12 @@ static class HeartbeatRequestState extends RequestState {
private long heartbeatIntervalMs;
public HeartbeatRequestState(
- final LogContext logContext,
- final Time time,
- final long heartbeatIntervalMs,
- final long retryBackoffMs,
- final long retryBackoffMaxMs,
- final double jitter) {
+ final LogContext logContext,
+ final Time time,
+ final long heartbeatIntervalMs,
+ final long retryBackoffMs,
+ final long retryBackoffMaxMs,
+ final double jitter) {
Review Comment:
Personally, I disagree in this case. It means the parameters are not
indented to exactly the same level as the statements that follow aiding
readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
