bachmanity1 commented on code in PR #16968:
URL: https://github.com/apache/kafka/pull/16968#discussion_r1729178685
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1397,20 +1397,15 @@ class KafkaApis(val requestChannel: RequestChannel,
trace("Sending topic metadata %s and brokers %s for correlation id %d to
client %s".format(completeTopicMetadata.mkString(","),
brokers.mkString(","), request.header.correlationId,
request.header.clientId))
- val controllerId = {
Review Comment:
Yeah, I know that KIP-919 doesn't mention anything about controller ID in
the MetadataResponse. I was just wondering if it makes sense to return a random
broker ID as a controller ID, I think it's better to return the real controller
ID because now clients are able to directly with controllers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
