cmccabe commented on code in PR #16968:
URL: https://github.com/apache/kafka/pull/16968#discussion_r1729461523
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1397,20 +1397,15 @@ class KafkaApis(val requestChannel: RequestChannel,
trace("Sending topic metadata %s and brokers %s for correlation id %d to
client %s".format(completeTopicMetadata.mkString(","),
brokers.mkString(","), request.header.correlationId,
request.header.clientId))
- val controllerId = {
Review Comment:
@mumrah is right here. The "real controller ID" is not a broker ID. For
example, you might have brokers 0, 1, and 2, and controllers 1001, 1002, and
1003. Returning 1001 would break many clients because they expect to use the
returned value as a broker ID. This is explained in various KIPs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
