gharris1727 commented on PR #16950: URL: https://github.com/apache/kafka/pull/16950#issuecomment-2307791737
Hey @chia7712 @KTKTK-HZ, this PR contents does not match the ticket or the PR title. By restructuring the build.gradle, I meant that the shadowJar block should be moved above the publishing block. That is not happening in this PR, only changing the fork is. Please update the PR to match the ticket, and/or create a new ticket for upgrading/changing the fork. I did validate the published artifact and observed that the classifier is correct (i.e. not present). This is because the 8.3.0 release does not have the https://github.com/Goooler/shadow/pull/80 patch that caused us to revert versions most recently, so this PR should not cause a regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
