bachmanity1 commented on code in PR #16990:
URL: https://github.com/apache/kafka/pull/16990#discussion_r1729537368
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/ConfigurationUtils.java:
##########
@@ -209,6 +209,19 @@ public String validateString(String name, boolean
isRequired) throws ValidateExc
return value;
}
+ /**
+ * Validates that a value, if supplied, is a {@link Boolean}. If no value
is present in the configuration, a
+ * default value of {@link Boolean#FALSE} is returned.
+ */
+ public Boolean validateBoolean(String name) {
Review Comment:
maybe it would be better to pass default value as an argument to this method
and change to something like this:
```java
cu.validateBoolean(SASL_OAUTHBEARER_HEADER_URLENCODE,
DEFAULT_SASL_OAUTHBEARER_HEADER_URLENCODE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
