kirktrue commented on code in PR #16990:
URL: https://github.com/apache/kafka/pull/16990#discussion_r1733544806
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/ConfigurationUtils.java:
##########
@@ -209,6 +209,15 @@ public String validateString(String name, boolean
isRequired) throws ValidateExc
return value;
}
+ public Boolean validateBoolean(String name, boolean isRequired) {
+ Boolean value = get(name);
+
+ if (value == null && isRequired)
+ throw new ConfigException(name, null, String.format("The OAuth
configuration option %s must be non-null", name));
Review Comment:
Ah! Good catch!
Since I brazenly stole that code from one of the other validation methods,
it looks like I should change the other occurrences too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
