junrao commented on code in PR #16873:
URL: https://github.com/apache/kafka/pull/16873#discussion_r1733069512
##########
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##########
@@ -82,8 +82,13 @@ else if (requireTimestamp)
return new Builder(minVersion,
ApiKeys.LIST_OFFSETS.latestVersion(), CONSUMER_REPLICA_ID, isolationLevel);
}
+ public static Builder forReplica(short allowedVersion, int replicaId,
boolean requireEarliestLocalTimestamp) {
+ short minVersion = requireEarliestLocalTimestamp ? (short) 8 :
(short) 0;
Review Comment:
@FrankYang0529 : Yes, the receiver does have the check. I am just saying
there is no need to add the code here since it's intended for the sender, but
the sender doesn't execute the added logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
