lianetm commented on code in PR #16844:
URL: https://github.com/apache/kafka/pull/16844#discussion_r1736044010
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -922,7 +922,11 @@ public void
testEnsureBackoffRetryOnOffsetCommitRequestTimeout() {
assertRetryBackOff(commitRequestManager, retryBackoffMs);
}
- private void assertCoordinatorDisconnect() {
+ private void assertCoordinatorDisconnectOnDisconnect() {
Review Comment:
names got a bit confusing with the other func I would say. Would it be
clearer if we rename this one to show that it's about
assertCoordinatorDisconnectHandling maybe? (it may or may not be a coordinator
disconnect, depending on the specific error, but we ensure it's being handled)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
