frankvicky commented on code in PR #16844:
URL: https://github.com/apache/kafka/pull/16844#discussion_r1738393452


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##########
@@ -122,6 +123,23 @@ NetworkClientDelegate.UnsentRequest 
makeFindCoordinatorRequest(final long curren
         });
     }
 
+    /**
+     * Handles the disconnection of the current coordinator.
+     * This method checks if the given exception is an instance of {@link 
DisconnectException}.
+     * If so, it marks the coordinator as unknown, indicating that the client 
should
+     * attempt to discover a new coordinator. For any other exception type, no 
action is performed.
+     *
+     * @param exception     The exception to handle, which was received as 
part of a request response.
+     *                      If this is an instance of {@link 
DisconnectException}, the coordinator is marked as unknown.
+     *                      For other types of exceptions, no action is 
performed.

Review Comment:
   Yes, it's a little verbose. I will remove it 👍🏼 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to