chia7712 commented on code in PR #16964:
URL: https://github.com/apache/kafka/pull/16964#discussion_r1739698765
##########
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandOptions.java:
##########
@@ -83,6 +84,13 @@ public ReassignPartitionsCommandOptions(String[] args) {
.withRequiredArg()
.describedAs("brokerlist")
.ofType(String.class);
+
+ bootstrapControllerOpt = parser.accepts("bootstrap-controller", "The
controller to use for reassignment. " +
+ "By default, the tool will get the controller from the
broker.")
Review Comment:
`the tool will get the controller from the broke` this description is not
correct. The controller is "quorum controller" rather than "broker controller"
##########
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandArgsTest.java:
##########
@@ -29,7 +29,7 @@
@Timeout(60)
public class ReassignPartitionsCommandArgsTest {
- public static final String MISSING_BOOTSTRAP_SERVER_MSG = "Please specify
--bootstrap-server";
+ public static final String MISSING_BOOTSTRAP_SERVER_MSG = "Please specify
either --bootstrap-server";
Review Comment:
why we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
