m1a2st commented on code in PR #16964:
URL: https://github.com/apache/kafka/pull/16964#discussion_r1740091030
##########
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandArgsTest.java:
##########
@@ -29,7 +29,7 @@
@Timeout(60)
public class ReassignPartitionsCommandArgsTest {
- public static final String MISSING_BOOTSTRAP_SERVER_MSG = "Please specify
--bootstrap-server";
+ public static final String MISSING_BOOTSTRAP_SERVER_MSG = "Please specify
either --bootstrap-server";
Review Comment:
I change the error message in validate method, thus these error message
should be changed
```java
if (opts.options.has(opts.bootstrapServerOpt) &&
opts.options.has(opts.bootstrapControllerOpt))
CommandLineUtils.printUsageAndExit(opts.parser, "Please don't specify
both --bootstrap-server and --bootstrap-controller");
else if (!opts.options.has(opts.bootstrapServerOpt) &&
!opts.options.has(opts.bootstrapControllerOpt))
CommandLineUtils.printUsageAndExit(opts.parser, "Please specify either
--bootstrap-server or --bootstrap-controller");
else
bootstrapOpt = opts.options.has(opts.bootstrapServerOpt) ?
opts.bootstrapServerOpt : opts.bootstrapControllerOpt;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
