AndrewJSchofield commented on code in PR #16885:
URL: https://github.com/apache/kafka/pull/16885#discussion_r1741726030
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##########
@@ -431,14 +424,14 @@ protected CompletableFuture<Void>
resetPositionsIfNeeded() {
* detected, a {@link LogTruncationException} will be saved in memory, to
be thrown on the
* next call to this function.
Review Comment:
I suppose that `cachedUpdatePositionsException` is involved here and it
might be worth mentioned that in the comment.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##########
@@ -373,6 +355,17 @@ private CompletableFuture<Void>
initWithCommittedOffsetsIfNeeded(long deadlineMs
return result;
}
+ private Map<TopicPartition, OffsetAndMetadata>
offsetsForInitializingPartitions(Map<TopicPartition, OffsetAndMetadata>
offsets) {
Review Comment:
Comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
