AndrewJSchofield commented on code in PR #16885:
URL: https://github.com/apache/kafka/pull/16885#discussion_r1742204551
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -99,12 +99,8 @@ public void process(ApplicationEvent event) {
process((ListOffsetsEvent) event);
return;
- case RESET_POSITIONS:
- process((ResetPositionsEvent) event);
- return;
-
- case VALIDATE_POSITIONS:
- process((ValidatePositionsEvent) event);
+ case UPDATE_FETCH_POSITIONS:
+ process((CheckPositionsAndMaybeUpdate) event);
Review Comment:
This is all so nice, but then the new event type doesn't match the class
name, and that convention has been followed so far. I suggest
`CHECK_AND_UPDATE_POSITIONS` and `CheckAndUpdatePositionsEvent` as not too
wordy and relatively accurate.
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManagerTest.java:
##########
@@ -101,15 +99,14 @@ public class OffsetsRequestManagerTest {
private static final IsolationLevel DEFAULT_ISOLATION_LEVEL =
IsolationLevel.READ_COMMITTED;
private static final int RETRY_BACKOFF_MS = 500;
private static final int REQUEST_TIMEOUT_MS = 500;
+ private static final int DEFAULT_API_TIMEOUT_MS = 500;
@BeforeEach
public void setup() {
LogContext logContext = new LogContext();
- backgroundEventQueue = new LinkedBlockingQueue<>();
- BackgroundEventHandler backgroundEventHandler = new
BackgroundEventHandler(backgroundEventQueue);
metadata = mock(ConsumerMetadata.class);
subscriptionState = mock(SubscriptionState.class);
- time = new MockTime(0);
+ // time = new MockTime(0);
Review Comment:
Probably didn't mean to leave this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
