smjn commented on code in PR #17011:
URL: https://github.com/apache/kafka/pull/17011#discussion_r1742573707
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1689,8 +1694,8 @@ class KafkaApis(val requestChannel: RequestChannel,
(txnCoordinator.partitionFor(key), TRANSACTION_STATE_TOPIC_NAME)
case CoordinatorType.SHARE =>
- // When share coordinator support is implemented in KIP-932, a
proper check will go here
- return (Errors.COORDINATOR_NOT_AVAILABLE, Node.noNode)
+ // None check already done above
Review Comment:
Sharecoordinator is an Optional. The line below the comment is directly
calling Sharecoordinator.get, because the case shareCoordinator.isEmpty check
is already done in line 1703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
