kamalcph commented on code in PR #16602: URL: https://github.com/apache/kafka/pull/16602#discussion_r1747114987
########## core/src/test/java/kafka/log/remote/RemoteLogOffsetReaderTest.java: ########## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package kafka.log.remote; + +import kafka.log.AsyncOffsetReadFutureHolder; +import kafka.utils.TestUtils; + +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.config.AbstractConfig; +import org.apache.kafka.common.metrics.Metrics; +import org.apache.kafka.common.utils.Utils; +import org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig; +import org.apache.kafka.server.log.remote.storage.RemoteStorageException; +import org.apache.kafka.server.util.MockTime; +import org.apache.kafka.storage.internals.checkpoint.LeaderEpochCheckpointFile; +import org.apache.kafka.storage.internals.epoch.LeaderEpochFileCache; +import org.apache.kafka.storage.internals.log.LogDirFailureChannel; +import org.apache.kafka.storage.log.metrics.BrokerTopicStats; + +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.List; +import java.util.Optional; +import java.util.Properties; +import java.util.concurrent.RejectedExecutionException; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; +import java.util.concurrent.locks.ReadWriteLock; +import java.util.concurrent.locks.ReentrantReadWriteLock; + +import scala.Option; +import scala.util.Either; + +import static org.apache.kafka.common.record.FileRecords.TimestampAndOffset; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +class RemoteLogOffsetReaderTest { + + private final MockTime time = new MockTime(); + private final TopicPartition topicPartition = new TopicPartition("test", 0); + private Path logDir; + private LeaderEpochFileCache cache; + private MockRemoteLogManager rlm; + + @BeforeEach + void setUp() throws IOException { + logDir = Files.createTempDirectory("kafka-test"); + LeaderEpochCheckpointFile checkpoint = new LeaderEpochCheckpointFile(TestUtils.tempFile(), new LogDirFailureChannel(1)); + cache = new LeaderEpochFileCache(topicPartition, checkpoint, time.scheduler); + rlm = new MockRemoteLogManager(2, 10, logDir.toString()); + } + + @AfterEach + void tearDown() throws IOException { + rlm.close(); + Utils.delete(logDir.toFile()); + } + + @Test + public void testReadRemoteLog() throws Exception { + AsyncOffsetReadFutureHolder<Either<Exception, Option<TimestampAndOffset>>> asyncOffsetReadFutureHolder = + rlm.asyncOffsetRead(topicPartition, time.milliseconds(), 0L, cache, Option::empty); + asyncOffsetReadFutureHolder.taskFuture().get(1, TimeUnit.SECONDS); + assertTrue(asyncOffsetReadFutureHolder.taskFuture().isDone()); + + Either<Exception, Option<TimestampAndOffset>> result = asyncOffsetReadFutureHolder.taskFuture().get(); + assertFalse(result.isLeft()); + assertTrue(result.isRight()); + assertEquals(Option.apply(new TimestampAndOffset(100L, 90L, Optional.of(3))), + result.right().get()); + } + + @Test + public void testTaskQueueFullAndCancelTask() throws Exception { + rlm.pause(); + + List<AsyncOffsetReadFutureHolder<Either<Exception, Option<TimestampAndOffset>>>> holderList = new ArrayList<>(); + // Task queue size is 10 and number of threads is 2, so it can accept at-most 12 items + for (int i = 0; i < 12; i++) { + holderList.add(rlm.asyncOffsetRead(topicPartition, time.milliseconds(), 0L, cache, Option::empty)); + } + assertThrows(TimeoutException.class, () -> holderList.get(0).taskFuture().get(10, TimeUnit.MILLISECONDS)); + assertEquals(0, holderList.stream().filter(h -> h.taskFuture().isDone()).count()); + + assertThrows(RejectedExecutionException.class, () -> + holderList.add(rlm.asyncOffsetRead(topicPartition, time.milliseconds(), 0L, cache, Option::empty))); + + holderList.get(2).jobFuture().cancel(false); Review Comment: The reason for maintaining 2 futures: `jobFuture` and `taskFuture` is to trigger the delayed operation completion (`delayedRemoteListOffsetsPurgatory#checkAndComplete(key)`) in the same remote-log-reader thread. When all the partitions results are received, then the delayedOperation gets completed. There is no relationship between the `jobFuture` and `taskFuture`. We call `jobFuture#cancel` only when the delayedOperation gets expired. So, either completing the `taskFuture` or not won't have any effect as the `taskFuture` result won't be used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
