dimitarndimitrov opened a new pull request, #17184:
URL: https://github.com/apache/kafka/pull/17184

   ### About 
   Addresses the race described 
[here](https://github.com/apache/kafka/pull/16949#discussion_r1750273695) and 
adds a JMH benchmark comparing `HdrHistogram` with Yammer's histogram.
   
   - A sample result from a local run on my development machine:
   ```
   Benchmark                                        Mode  Cnt    Score     
Error  Units
   HistogramBenchmark.runner                        avgt    5  410.811 ±  
95.204  ns/op
   HistogramBenchmark.runner:read_HdrHistogram      avgt    5   50.839 ±  
11.850  ns/op
   HistogramBenchmark.runner:read_YammerHistogram   avgt    5   51.206 ±  
11.789  ns/op
   HistogramBenchmark.runner:write_HdrHistogram     avgt    5  314.767 ±  
93.978  ns/op
   HistogramBenchmark.runner:write_YammerHistogram  avgt    5  986.574 ± 
214.357  ns/op
   ```
   
   ### Testing
   
   I haven't included a test reproducing the race, because on my development 
machine I wasn't able to see consistent reproducibility without more 
sophisticated testing tools like jcstress or Byteman/BMUnit. The race is easily 
reproducible manually while debugging the test.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to