dimitarndimitrov opened a new pull request, #17221: URL: https://github.com/apache/kafka/pull/17221
### About An encore of #17184, this addresses the race described https://github.com/apache/kafka/pull/16949#discussion_r1750273695 and adds a JMH benchmark comparing `HdrHistogram` with Yammer's histogram. It also addresses some nits from that previous PR and rebases on top of the #17011 changes. A sample result from a local run on my development machine: ``` Benchmark Mode Cnt Score Error Units HistogramBenchmark.runner avgt 5 422.372 ± 13.081 ns/op HistogramBenchmark.runner:readHdrHistogram avgt 5 50.952 ± 1.330 ns/op HistogramBenchmark.runner:readYammerHistogram avgt 5 51.249 ± 1.319 ns/op HistogramBenchmark.runner:writeHdrHistogram avgt 5 319.489 ± 52.221 ns/op HistogramBenchmark.runner:writeYammerHistogram avgt 5 1020.283 ± 18.695 ns/op ``` ### Testing In addition to the JMH benchmark, and unlike the original PR, #17184, this also includes a fairly reliable test for the race that's being fixed. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
