chia7712 commented on code in PR #17181:
URL: https://github.com/apache/kafka/pull/17181#discussion_r1758115374
##########
.github/workflows/build.yml:
##########
@@ -141,3 +144,11 @@ jobs:
with:
name: build-scan-test-${{ matrix.java }}
path: ~/.gradle/build-scan-data
Review Comment:
(this comment is unrelated to this PR)
Should we add `compression-level: 9` to this archive as all of them are
plaintext.
##########
.github/workflows/build.yml:
##########
@@ -141,3 +144,11 @@ jobs:
with:
name: build-scan-test-${{ matrix.java }}
path: ~/.gradle/build-scan-data
+ - name: Archive Thread Dumps
Review Comment:
Maybe the artifact url generated by this task should be passed to "Parse
JUnit tests". Than can enable "Parse JUnit tests" to add url to summary (like
junit reports)
##########
.github/workflows/build.yml:
##########
@@ -141,3 +144,11 @@ jobs:
with:
name: build-scan-test-${{ matrix.java }}
path: ~/.gradle/build-scan-data
Review Comment:
(this comment is unrelated to this PR)
Should we add `compression-level: 9` to this archive as all of them are
plaintext.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
