chia7712 commented on code in PR #17181:
URL: https://github.com/apache/kafka/pull/17181#discussion_r1759031592
##########
.github/scripts/junit.py:
##########
@@ -259,9 +259,15 @@ def pretty_time_duration(seconds: float) -> str:
# Print special message if there was a timeout
exit_code = get_env("GRADLE_EXIT_CODE", int)
if exit_code == 124:
+ thread_dump_url = get_env("THREAD_DUMP_URL")
logger.debug(f"Gradle command timed out. These are partial results!")
logger.debug(summary)
- logger.debug("Failing this step because the tests timed out.")
+ if thread_dump_url:
+ print("\nThe JUnit tests were cancelled due to a timeout. Thread
dumps were generated before the job was cancelled. "
+ "Download [thread dumps]({thread_dump_url}).\n")
Review Comment:
I guess it needs to be `F-Strings`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
