mjsax commented on code in PR #17169:
URL: https://github.com/apache/kafka/pull/17169#discussion_r1759247507
##########
streams/src/main/java/org/apache/kafka/streams/errors/ErrorHandlerContext.java:
##########
@@ -42,6 +42,8 @@ public interface ErrorHandlerContext {
* {@link
org.apache.kafka.streams.kstream.KTable#transformValues(ValueTransformerWithKeySupplier,
String...)}
* (and siblings), that do not always guarantee to provide a valid topic
name, as they might be
* executed "out-of-band" due to some internal optimizations applied by
the Kafka Streams DSL.
+ * Additionally, when writing into a changelog topic, there is no
associated input record,
+ * and thus no topic name is available.
Review Comment:
In general I agree, but I would not be too strict about in-line comments --
they can be very helpful to explain important context, which cannot be
expressed by code itself IMHO.
I did push another smaller change that I think is valuable for 3.9 release,
but will leave it to follow up PRs to improve this further fro 4.0+ release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
