kamalcph commented on code in PR #16602:
URL: https://github.com/apache/kafka/pull/16602#discussion_r1759305127
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1447,11 +1466,119 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ def fetchOffset(topics: Seq[ListOffsetsTopic],
+ duplicatePartitions: Set[TopicPartition],
+ isolationLevel: IsolationLevel,
+ replicaId: Int,
+ clientId: String,
+ correlationId: Int,
+ version: Short,
+ buildErrorResponse: (Errors, ListOffsetsPartition) =>
ListOffsetsPartitionResponse,
+ responseCallback: List[ListOffsetsTopicResponse] => Unit):
Unit = {
+ val statusByPartition = mutable.Map[TopicPartition,
ListOffsetsPartitionStatus]()
+ topics.foreach { topic =>
+ topic.partitions.asScala.foreach { partition =>
+ val topicPartition = new TopicPartition(topic.name,
partition.partitionIndex)
+ if (duplicatePartitions.contains(topicPartition)) {
+ debug(s"OffsetRequest with correlation id $correlationId from client
$clientId on partition $topicPartition " +
+ s"failed because the partition is duplicated in the request.")
+ statusByPartition += topicPartition ->
ListOffsetsPartitionStatus(Some(buildErrorResponse(Errors.INVALID_REQUEST,
partition)))
+ } else if (isListOffsetsTimestampUnsupported(partition.timestamp(),
version)) {
+ statusByPartition += topicPartition ->
ListOffsetsPartitionStatus(Some(buildErrorResponse(Errors.UNSUPPORTED_VERSION,
partition)))
+ } else {
+ try {
+ val fetchOnlyFromLeader = replicaId !=
ListOffsetsRequest.DEBUGGING_REPLICA_ID
+ val isClientRequest = replicaId ==
ListOffsetsRequest.CONSUMER_REPLICA_ID
+ val isolationLevelOpt = if (isClientRequest)
+ Some(isolationLevel)
+ else
+ None
+
+ val resultHolder = fetchOffsetForTimestamp(topicPartition,
+ partition.timestamp,
+ isolationLevelOpt,
+ if (partition.currentLeaderEpoch ==
ListOffsetsResponse.UNKNOWN_EPOCH) Optional.empty() else
Optional.of(partition.currentLeaderEpoch),
+ fetchOnlyFromLeader)
+
+ val status = resultHolder match {
+ case OffsetResultHolder(Some(found), _) =>
Review Comment:
This PR is large. I'll address the refactoring in the next PR. Is it fine?
> please add comments for those cases at least?
Added comments. Let me know if it needs to be improved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
