[
https://issues.apache.org/jira/browse/KAFKA-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881729#comment-17881729
]
Matthias J. Sax commented on KAFKA-17488:
-----------------------------------------
Yes, that correct.
Btw, with regard to the comments I left on the PR review, cf "rejected
alternatives" of KIP-743:
{quote} * *Removing the complete config* {{{*}built.in.metrics.version{*}:}}
The config can still be used for future changes to the built-in metrics.{quote}
> Cleanup (test) code for Kafka Streams "metric version"
> ------------------------------------------------------
>
> Key: KAFKA-17488
> URL: https://issues.apache.org/jira/browse/KAFKA-17488
> Project: Kafka
> Issue Type: Task
> Components: streams, unit tests
> Reporter: Matthias J. Sax
> Assignee: João Pedro Fonseca
> Priority: Minor
>
> In Kafka Streams, we move from old metrics to new metrics, and added a config
> for users to explicitly opt into using the new metric.
> While we did remove old metric in the code base completely, we kept the
> config (what is desired, as if we make a similar change in the future the
> config would just be there), however, there is still code left which still
> uses the config for no good reason (especially test code).
> It might be worth to cleanup a little bit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
