[ 
https://issues.apache.org/jira/browse/KAFKA-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882743#comment-17882743
 ] 

João Pedro Fonseca commented on KAFKA-17488:
--------------------------------------------

In fact, I have considered not to remove the built.in.metrics.version as it 
matches to "if we make a similar change in the future the config would just be 
there", but I was in doubt about it so I have removed it. I will revert it! 
Thanks, [~mjsax]! :)

> Cleanup (test) code for Kafka Streams "metric version"
> ------------------------------------------------------
>
>                 Key: KAFKA-17488
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17488
>             Project: Kafka
>          Issue Type: Task
>          Components: streams, unit tests
>            Reporter: Matthias J. Sax
>            Assignee: João Pedro Fonseca
>            Priority: Minor
>
> In Kafka Streams, we move from old metrics to new metrics, and added a config 
> for users to explicitly opt into using the new metric.
> While we did remove old metric in the code base completely, we kept the 
> config (what is desired, as if we make a similar change in the future the 
> config would just be there), however, there is still code left which still 
> uses the config for no good reason (especially test code).
> It might be worth to cleanup a little bit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to