chia7712 commented on code in PR #17210:
URL: https://github.com/apache/kafka/pull/17210#discussion_r1762317560


##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -967,7 +967,7 @@ class KafkaConfig private(doLog: Boolean, val props: 
util.Map[_, _])
       // ZK-based
       if (migrationEnabled) {
         require(brokerId >= 0,
-          "broker broker.id.generation.enable is incompatible with migration 
to ZK. Please disable it before enabling migration")
+          "broker.id generation is incompatible with ZooKeeper migration. 
Please stop using it before enabling migration (set broker.id to a value 
greater or equal to 0).")

Review Comment:
   Maybe we should just say "please define the broker.id for migration"? It can 
fail due to undefined broker.if even though we have disabled generation.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to