scholzj commented on code in PR #17210:
URL: https://github.com/apache/kafka/pull/17210#discussion_r1762659231
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -847,7 +847,7 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
}
if (brokerIdGenerationEnable) {
if (migrationEnabled) {
- require(brokerId != -1, "broker id generation is incompatible with
migration to ZK. Please disable it before enabling migration")
+ require(brokerId != -1, "broker.id generation is incompatible with
ZooKeeper migration. Please stop using it before enabling migration (set
broker.id to a value greater or equal to 0).")
Review Comment:
I updated it to `>= 0`. It makes sense to use the same in all checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
