showuon commented on code in PR #17112:
URL: https://github.com/apache/kafka/pull/17112#discussion_r1773191138
##########
clients/src/main/resources/common/message/ListOffsetsRequest.json:
##########
@@ -36,7 +36,9 @@
// Version 8 enables listing offsets by local log start offset (KIP-405).
//
// Version 9 enables listing offsets by last tiered offset (KIP-1005).
- "validVersions": "0-9",
+ //
+ // Version 10 enables async remote list offsets support (KIP-1075)
+ "validVersions": "0-10",
Review Comment:
Yes, I think this is required.
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -221,6 +221,7 @@ public enum MetadataVersion {
IBP_4_0_IV1(23, "4.0", "IV1", true),
// Bootstrap metadata version for transaction versions 1 and 2 (KIP-890)
+ // Enables async remote LIST_OFFSETS support (KIP-1075)
IBP_4_0_IV2(24, "4.0", "IV2", false);
Review Comment:
Let's create `IBP_4_0_IV3` for KIP-1075 to make each MV clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
