mumrah commented on PR #17112: URL: https://github.com/apache/kafka/pull/17112#issuecomment-2377323567
@satishd @showuon this PR broke some tests and has caused trunk builds to fail. The latest CI run for this PR was https://github.com/apache/kafka/actions/runs/11027485627 which shows both of the JUnit steps failing. Unlike with Jenkins, we need to look at _every_ failed test build -- especially before merging. Looking at these two failed jobs, we can see we have actual failed tests and not just flaky ones <img width="1126" alt="image" src="https://github.com/user-attachments/assets/f02251bc-5dff-4d22-92e1-b4e01a5153fe";> https://github.com/apache/kafka/actions/runs/11027485627/job/30626323008 We want to see all the status checks in the PR to be green before merging. I would like to have branch protections in place to prevent this sort of regression, but until we sort out the flaky tests we can't really. Anyways, I'm not meaning to pick on this PR -- just trying to raise awareness of our "new normal" for build expectations :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
