apoorvmittal10 commented on code in PR #17021: URL: https://github.com/apache/kafka/pull/17021#discussion_r1775454686
########## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ########## @@ -621,6 +631,9 @@ private KafkaAdminClient(AdminClientConfig config, retryBackoffMaxMs, CommonClientConfigs.RETRY_BACKOFF_JITTER); this.clientTelemetryEnabled = config.getBoolean(AdminClientConfig.ENABLE_METRICS_PUSH_CONFIG); + List<MetricsReporter> reporters = CommonClientConfigs.metricsReporters(this.clientId, config); + this.clientTelemetryReporter = clientTelemetryReporter; + this.clientTelemetryReporter.ifPresent(reporters::add); Review Comment: Hmmm, but the close will not send the last telemetry push as ClientTelemetryReporter need `initiateClose` method call to set state as `terminating_push_needed` which sends the last telemetry metrics to broker. However if we decide not to send last telemetry push in admin client that's fine but we should write it in comments somewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org