apoorvmittal10 commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1779102908
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -547,6 +551,8 @@ static KafkaAdminClient createInternal(
MetricsContext metricsContext = new KafkaMetricsContext(JMX_PREFIX,
config.originalsWithPrefix(CommonClientConfigs.METRICS_CONTEXT_PREFIX));
metrics = new Metrics(metricConfig, reporters, time,
metricsContext);
+ clientTelemetryReporter =
CommonClientConfigs.telemetryReporter(clientId, config);
+ clientTelemetryReporter.ifPresent(telemetryReporter ->
telemetryReporter.contextChange(metricsContext));
Review Comment:
That sounds fair to me. For my knowledge, does admin client in streams
application has a long running connection where metrics will be emitted? My
concern is with if connections are adhoc and we do create too many admin client
short lived connections then it might impact the connection cache i.e.
connection cache keeps the client instance for maximum of push interval * 3 ms
hence if too many admin client connections created in short span then it might
hurt the performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
