TaiJuWu commented on code in PR #17168:
URL: https://github.com/apache/kafka/pull/17168#discussion_r1776371598
##########
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsConfigs.java:
##########
@@ -131,9 +131,11 @@ private static void validateProperties(Properties
properties) {
}
});
+ ClientMetricsConfigs configs = new ClientMetricsConfigs(properties);
Review Comment:
> I am not convinced instantiating `ClientMetricsConfigs(properties)` in the
validate method. The idea with validate is to create `ClientMetricsConfigs`
instance only after post validating the configs are correct.
>
> I understand we want to thrown `invalid request exception` when configs
are not correct and as per the changes I am assuming that the unknown server
occurs when the int config is specified as non-int, correct? If that's the only
scenario then we can handle directly. Am I reading something wrong here?
Yes, you are right and I updated this part by utilize `ConfigDef.parseType`.
PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
