TaiJuWu commented on code in PR #17168:
URL: https://github.com/apache/kafka/pull/17168#discussion_r1759638418
##########
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsConfigs.java:
##########
@@ -131,9 +131,11 @@ private static void validateProperties(Properties
properties) {
}
});
+ ClientMetricsConfigs configs = new ClientMetricsConfigs(properties);
Review Comment:
Hi @chia7712 , thanks for review.
The situation can't happen because `Line 120` checks the properties which is
defined at `Line 102` and they have default value except `PUSH_INTERVAL_MS `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
