apoorvmittal10 commented on code in PR #17264:
URL: https://github.com/apache/kafka/pull/17264#discussion_r1778757279
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -981,10 +981,6 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
val groupResource = new ConfigResource(ConfigResource.Type.GROUP,
"none_group")
val groupResult =
client.describeConfigs(Seq(groupResource).asJava).all().get().get(groupResource)
assertNotEquals(0, groupResult.entries().size())
-
- val metricResource = new
ConfigResource(ConfigResource.Type.CLIENT_METRICS, "none_metric")
- val metricResult =
client.describeConfigs(Seq(metricResource).asJava).all().get().get(metricResource)
- assertEquals(0, metricResult.entries().size())
Review Comment:
Why do need to remove this line? Is it because now default configs will
always appear for unknown subscription? Will it add confusion when describing?
Should we just add a note in describe that if subscription doesn not exist then
default values will be displayed, and check for subscriptions list to find
which all subscriptions are applied to the cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
