AndrewJSchofield commented on code in PR #17264:
URL: https://github.com/apache/kafka/pull/17264#discussion_r1778797576
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -981,10 +981,6 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
val groupResource = new ConfigResource(ConfigResource.Type.GROUP,
"none_group")
val groupResult =
client.describeConfigs(Seq(groupResource).asJava).all().get().get(groupResource)
assertNotEquals(0, groupResult.entries().size())
-
- val metricResource = new
ConfigResource(ConfigResource.Type.CLIENT_METRICS, "none_metric")
- val metricResult =
client.describeConfigs(Seq(metricResource).asJava).all().get().get(metricResource)
- assertEquals(0, metricResult.entries().size())
Review Comment:
Well, yes, that's what happens. Previously, if you displayed a non-existent
resource, it didn't say "This doesn't exist", it just printed an empty list.
Now, it prints the defaults. What ideally would happen is that it would say
"This resource doesn't exist." but I think that's tricky to achieve. If you
have ideas here, let me know. I'd prefer if the resource was flagged as an
error in this case but the client metrics config manager in the broker is a
tricky beast I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
