frankvicky commented on code in PR #17426: URL: https://github.com/apache/kafka/pull/17426#discussion_r1793681057
########## gradle/spotbugs-exclude.xml: ########## @@ -547,5 +547,10 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read </Or> <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/> </Match> + <Match> + <!-- Suppress warning about using static DateFormat in a multithreaded context --> + <Class name="org.apache.kafka.tools.ReplicaVerificationTool$ReplicaBuffer"/> + <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/> + </Match> Review Comment: No, it might be a concern, but I suppress it since this test is going to be deleted. I don't think it's very meaningful to fix it at this moment. 🤔 https://github.com/apache/kafka/blob/bb6ebd83f9a0f9b2a37704f1f37b78a48cf480e1/tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java#L115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
