apoorvmittal10 commented on code in PR #17450:
URL: https://github.com/apache/kafka/pull/17450#discussion_r1795174473
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -2368,7 +2368,7 @@ public SharePartitionManager build() {
persister,
delayedShareFetchPurgatory,
delayedActionsQueue,
- new GroupConfigManager(new HashMap<>()),
+ mock(GroupConfigManager.class),
Review Comment:
Hmmm, though it's fine to mock it but why we did if we are not changing any
handling in SharePartitionManagerTests?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -63,6 +71,18 @@ public class GroupConfig extends AbstractConfig {
atLeast(1),
MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
+ .define(SHARE_SESSION_TIMEOUT_MS_CONFIG,
+ INT,
+ GroupCoordinatorConfig.SHARE_GROUP_SESSION_TIMEOUT_MS_DEFAULT,
+ atLeast(1),
Review Comment:
KIP defines `share.min.session.timeout.ms ` as 45 secs but we do not have
any range defined for `share.session.timeout.ms`. Though I understand that in
other places as well (`heartbeat.interval.ms`) there is no valid range defined
but just writing it down to get the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
