chirag-wadhwa5 commented on code in PR #17450:
URL: https://github.com/apache/kafka/pull/17450#discussion_r1795202427
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -2368,7 +2368,7 @@ public SharePartitionManager build() {
persister,
delayedShareFetchPurgatory,
delayedActionsQueue,
- new GroupConfigManager(new HashMap<>()),
+ mock(GroupConfigManager.class),
Review Comment:
Hi, thanks for the review. This change should have gone in the previous PR.
I got a comment to change the instance of GroupConfigManager to a mock, but I
missed that change in SharePartitionManager. I can create a separate PR for
this as well if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
