aliehsaeedii commented on code in PR #17414:
URL: https://github.com/apache/kafka/pull/17414#discussion_r1795584142
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##########
@@ -583,7 +583,7 @@ public synchronized ConsumerRecords<K, V> poll(final
Duration timeout) {
final ShareFetch<K, V> fetch = pollForFetches(timer);
if (!fetch.isEmpty()) {
currentFetch = fetch;
- return new ConsumerRecords<>(fetch.records());
+ return new ConsumerRecords<>(fetch.records(),
Collections.emptyMap());
Review Comment:
> Trivial, but please test this in `ShareConsumerImplTest`.
Mmm. `ShareConsumerImplTest` does not test the returned records as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
