aliehsaeedii commented on code in PR #17414:
URL: https://github.com/apache/kafka/pull/17414#discussion_r1796969771
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##########
@@ -195,7 +196,7 @@ private Fetch<K, V> fetchRecords(final CompletedFetch
nextInLineFetch, int maxRe
metricsManager.recordPartitionLead(tp, lead);
}
- return Fetch.forPartition(tp, partRecords, positionAdvanced);
+ return Fetch.forPartition(tp, partRecords, positionAdvanced,
new OffsetAndMetadata(nextInLineFetch.nextFetchOffset(),
nextInLineFetch.lastEpoch(), ""));
Review Comment:
>we promise to return only those topic partitions that have fetched
something?
What is `something`? Can we distinguish a `real nothing` and a `control
record`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
